Fix regex for single digits

simplesamlphp · Jan 18, 2025 · 219e793 · 219e793
1 parent d731e36
commit 219e793
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/Assert/PositiveIntegerTrait.php b/src/Assert/PositiveIntegerTrait.php
@@ -12,7 +12,7 @@
 trait PositiveIntegerTrait
 {
     /** @var string */
-    private static string $positiveInteger_regex = '/^[+]?(\d+[1-9]$)$/D';
+    private static string $positiveInteger_regex = '/^[+]?(\d*[1-9]$)$/D';
 
 
     /**

diff --git a/tests/Assert/PositiveIntegerTest.php b/tests/Assert/PositiveIntegerTest.php
@@ -43,6 +43,7 @@ public static function providePositiveInteger(): array
             'empty' => [false, ''],
             'valid positive integer' => [true, '123456'],
             'valid signed positive integer' => [true, '+123456'],
+            'valid single digit' => [true, '3'],
             'invalid zero' => [false, '0'],
             'valid negative leading zeros' => [true, '0000000000000000000005'],
             'invalid with fractional' => [false, '1.'],

diff --git a/tests/Type/PositiveIntegerValueTest.php b/tests/Type/PositiveIntegerValueTest.php
@@ -45,6 +45,7 @@ public static function providePositiveInteger(): array
             'valid signed positive integer' => [true, '+123456'],
             'invalid zero' => [false, '0'],
             'valid negative leading zeros' => [true, '0000000000000000000005'],
+            'valid single digit' => [true, '3'],
             'valid with whitespace collapse' => [true, " 1 234 \n"],
             'invalid with fractional' => [false, '1.'],
             'invalid negative' => [false, '-1234'],