Properly constrain selection position when clicking on error message

simonpoole · Jan 25, 2025 · 2651c05 · 2651c05
1 parent ead8135
commit 2651c05
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -50,6 +50,6 @@ repositories {
 
 ``` groovy
 dependencies {
-    compile "ch.poole:OpeningHoursFragment:0.14.2"
+    compile "ch.poole:OpeningHoursFragment:0.14.3"
 }
 ```
diff --git a/lib/build.gradle b/lib/build.gradle
@@ -22,7 +22,7 @@ apply plugin: 'signing'
 apply plugin: "jacoco"
 apply plugin: "com.github.breadmoirai.github-release"
 
-version = '0.14.2'
+version = '0.14.3'
 def libName = "OpeningHoursFragment"
 
 task updateTranslations(type: Exec) {

diff --git a/lib/src/main/java/ch/poole/openinghoursfragment/OpeningHoursFragment.java b/lib/src/main/java/ch/poole/openinghoursfragment/OpeningHoursFragment.java
@@ -697,8 +697,8 @@ private void displayParseErrors(@NonNull OpeningHoursParseException pex) {
             message.setSingleLine();
             message.setText(ex.getMessage());
             message.setTextColor(ContextCompat.getColor(getContext(), R.color.error_text));
-            final int column = ex.getColumn() + 1;
-            message.setOnClickListener(v -> text.setSelection(column, Math.min(column + 1, message.length())));
+            final int column = Math.min(ex.getColumn() + 1, message.length() - 1);
+            message.setOnClickListener(v -> text.setSelection(column, column));
             errorMessages.addView(message);
         }
     }