Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show test durations #189

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

di
Copy link
Member

@di di commented Jan 23, 2025

Summary

Configure pytest to always print test durations per #188 (comment).

Release Note

NONE

Documentation

NONE

@jku
Copy link
Member

jku commented Jan 23, 2025

seems a bit verbose but certainly useful : I had no idea this happened:

30.87s setup test/test_bundle.py::test_verify_rejects_bad_tlog_entry[ArtifactInputType.PATH]

@di
Copy link
Member Author

di commented Jan 23, 2025

We could always just list the top N slowest durations instead?

@woodruffw
Copy link
Member

I'm OK with the verbosity if others are! But yeah, listing just the top N slowest would also be good!

(Unsurprisingly I suppose the CPython bundle tests are by far the slowest thing, at least for the Python selftest.)

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think something like "10 slowest" would be enough information in most cases but either way works for me

@woodruffw woodruffw merged commit a2dbf8d into sigstore:main Jan 23, 2025
5 checks passed
@di di deleted the show-test-durations branch January 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants