-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self-test: Install sigstore-python in separate virtualenv #181
Conversation
038c264
to
ec85a1d
Compare
This prevents sigstore dependencies from being accidentally used by the test suite. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
ec85a1d
to
9cce92f
Compare
Don't call two different things "sigstore-env" Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thinking out loud: one thing we could do to speed up our own CI/conformance consumers a bit is use uv
throughout. But that's totally unrelated to these fixes themselves 🙂
Trying to make sure I understand the goal here: we want to install |
@di the goal is to install sigstore-python so that it does not poison the virtual environment for the test suite: The practical issue was that e.g. #178 does not appear in our self test but does break every user. Current situation is:
The already merged #179 does prevent this specific poisoning issue but the core problem remains: if sigstore-python and the test suite want to use different dependency versions, they should be able to. This PR changes things so sigstore-python is installed in a separate venv. The only complication is that it makes the invocation a bit complicated (generated shell script calls the sigstore-python-conformance wrapper that calls "sigstore" binary): I'm pretty sure there is a simpler setup but it will require modifying the wrapper somehow |
I agree generating the script is not pretty but I'll merge as is: I think it still does the right thing and we can improve after the action is working again. see #185 for improvements |
* self-test: Install sigstore in separate virtualenv This prevents sigstore dependencies from being accidentally used by the test suite. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * selftest: Rename things Don't call two different things "sigstore-env" Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> Co-authored-by: William Woodruff <william@trailofbits.com>
This prevents sigstore-python dependencies from being accidentally used by the test suite.
Note that Makefile currently still installs everything in the same environment. Fixing this requires some additional work: either the documentation needs to include the use of venv when invoking the test suite manually (making the invocation even more complicated) or the sigstore-python-conformance entrypoint needs to somehow handle the virtual environment...
Fixes #180