-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for verifying v0.3 bundles #138
Merged
woodruffw
merged 2 commits into
sigstore:main
from
segiddins:segiddins/add-a-test-for-verifyting-v0.3-bundles
Mar 19, 2024
Merged
Add a test for verifying v0.3 bundles #138
woodruffw
merged 2 commits into
sigstore:main
from
segiddins:segiddins/add-a-test-for-verifyting-v0.3-bundles
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM behaviorally -- mind adding an
|
woodruffw
added
enhancement
New feature or request
component:tests
Unit and integration tests
labels
Mar 19, 2024
I think this is blocked by #136, I verified that HEAD of sigstore-python (and https://github.com/segiddins/sigstore-cosign-verify) pass the new spec |
Generated with ``` /Users/segiddins/Development/github.com/sigstore/sigstore-python/env/bin/sigstore sign test/assets/a.txt --bundle test/assets/a.txt.good.v0.3.sigstore --identity-token "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ikh5cTROQVRBanNucUM3bWRydEFoaHJDUjJfUSIsImtpZCI6IjFGMkFCODM0MDRDMDhFQzlFQTBCQjk5REFFRDAyMTg2QjA5MURCRjQifQ.eyJqdGkiOiI2ZDg3MWM5Ny05OTUwLTRiOWEtYmQ1Ny03Zjc1N2QyMWJhODMiLCJzdWIiOiJyZXBvOnNpZ3N0b3JlLWNvbmZvcm1hbmNlL2V4dHJlbWVseS1kYW5nZXJvdXMtcHVibGljLW9pZGMtYmVhY29uOnJlZjpyZWZzL2hlYWRzL21haW4iLCJhdWQiOiJzaWdzdG9yZSIsInJlZiI6InJlZnMvaGVhZHMvbWFpbiIsInNoYSI6ImM3YjNkZmIzMzVmMDUxZTFjODZiZGE0YzcxNmZhYzk3ZGY2MmFkODEiLCJyZXBvc2l0b3J5Ijoic2lnc3RvcmUtY29uZm9ybWFuY2UvZXh0cmVtZWx5LWRhbmdlcm91cy1wdWJsaWMtb2lkYy1iZWFjb24iLCJyZXBvc2l0b3J5X293bmVyIjoic2lnc3RvcmUtY29uZm9ybWFuY2UiLCJyZXBvc2l0b3J5X293bmVyX2lkIjoiMTMxODA0NTYzIiwicnVuX2lkIjoiODM0NzQ4MTYyOCIsInJ1bl9udW1iZXIiOiIxMDM3MDAiLCJydW5fYXR0ZW1wdCI6IjEiLCJyZXBvc2l0b3J5X3Zpc2liaWxpdHkiOiJwdWJsaWMiLCJyZXBvc2l0b3J5X2lkIjoiNjMyNTk2ODk3IiwiYWN0b3JfaWQiOiI0MTg5ODI4MiIsImFjdG9yIjoiZ2l0aHViLWFjdGlvbnNbYm90XSIsIndvcmtmbG93IjoiRXh0cmVtZWx5IGRhbmdlcm91cyBPSURDIGJlYWNvbiIsImhlYWRfcmVmIjoiIiwiYmFzZV9yZWYiOiIiLCJldmVudF9uYW1lIjoid29ya2Zsb3dfZGlzcGF0Y2giLCJyZWZfcHJvdGVjdGVkIjoidHJ1ZSIsInJlZl90eXBlIjoiYnJhbmNoIiwid29ya2Zsb3dfcmVmIjoic2lnc3RvcmUtY29uZm9ybWFuY2UvZXh0cmVtZWx5LWRhbmdlcm91cy1wdWJsaWMtb2lkYy1iZWFjb24vLmdpdGh1Yi93b3JrZmxvd3MvZXh0cmVtZWx5LWRhbmdlcm91cy1vaWRjLWJlYWNvbi55bWxAcmVmcy9oZWFkcy9tYWluIiwid29ya2Zsb3dfc2hhIjoiYzdiM2RmYjMzNWYwNTFlMWM4NmJkYTRjNzE2ZmFjOTdkZjYyYWQ4MSIsImpvYl93b3JrZmxvd19yZWYiOiJzaWdzdG9yZS1jb25mb3JtYW5jZS9leHRyZW1lbHktZGFuZ2Vyb3VzLXB1YmxpYy1vaWRjLWJlYWNvbi8uZ2l0aHViL3dvcmtmbG93cy9leHRyZW1lbHktZGFuZ2Vyb3VzLW9pZGMtYmVhY29uLnltbEByZWZzL2hlYWRzL21haW4iLCJqb2Jfd29ya2Zsb3dfc2hhIjoiYzdiM2RmYjMzNWYwNTFlMWM4NmJkYTRjNzE2ZmFjOTdkZjYyYWQ4MSIsInJ1bm5lcl9lbnZpcm9ubWVudCI6ImdpdGh1Yi1ob3N0ZWQiLCJpc3MiOiJodHRwczovL3Rva2VuLmFjdGlvbnMuZ2l0aHVidXNlcmNvbnRlbnQuY29tIiwibmJmIjoxNzEwODY4NDg4LCJleHAiOjE3MTA4NjkzODgsImlhdCI6MTcxMDg2OTA4OH0.ekOKylNncBuQpoS9TzqiJed0cUX3vEGitXZZket_paETLNSDz0rl9yZapPgRmKds4WirKpDhZDDgKNCV2bOCXZQ_mcU4dDshUQe8ppIJIkCCs6AUkxODVkioGmfJ6ggClzgZGR0qGd3gW0WgmRHSDfmUNeoWEgM4F_mIErTwhnVmmVWRc0iZtsDTQd8KFzSXeVRhKeibDcuCHTN1SmJEkAKfyjz3RWMlxnPCEs1oONtbzzaH9OvDoB0UkIs-IhiMNjuJcuH5b7HFL2aY-crPt0hE2rHvIIPWZeFKYtoD9_82tebx5VCrCBvU9Z5vGXpSwK6BeNnQzukNCu-5b0iopw" --overwrite ``` Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
segiddins
force-pushed
the
segiddins/add-a-test-for-verifyting-v0.3-bundles
branch
from
March 19, 2024 17:39
3ab944b
to
e7ebdc4
Compare
woodruffw
reviewed
Mar 19, 2024
Generated with ``` /Users/segiddins/Development/github.com/sigstore/sigstore-python/env/bin/sigstore sign test/assets/a.txt --bundle test/assets/a.txt.good.v0.3.sigstore --identity-token "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ikh5cTROQVRBanNucUM3bWRydEFoaHJDUjJfUSIsImtpZCI6IjFGMkFCODM0MDRDMDhFQzlFQTBCQjk5REFFRDAyMTg2QjA5MURCRjQifQ.eyJqdGkiOiI2ZDg3MWM5Ny05OTUwLTRiOWEtYmQ1Ny03Zjc1N2QyMWJhODMiLCJzdWIiOiJyZXBvOnNpZ3N0b3JlLWNvbmZvcm1hbmNlL2V4dHJlbWVseS1kYW5nZXJvdXMtcHVibGljLW9pZGMtYmVhY29uOnJlZjpyZWZzL2hlYWRzL21haW4iLCJhdWQiOiJzaWdzdG9yZSIsInJlZiI6InJlZnMvaGVhZHMvbWFpbiIsInNoYSI6ImM3YjNkZmIzMzVmMDUxZTFjODZiZGE0YzcxNmZhYzk3ZGY2MmFkODEiLCJyZXBvc2l0b3J5Ijoic2lnc3RvcmUtY29uZm9ybWFuY2UvZXh0cmVtZWx5LWRhbmdlcm91cy1wdWJsaWMtb2lkYy1iZWFjb24iLCJyZXBvc2l0b3J5X293bmVyIjoic2lnc3RvcmUtY29uZm9ybWFuY2UiLCJyZXBvc2l0b3J5X293bmVyX2lkIjoiMTMxODA0NTYzIiwicnVuX2lkIjoiODM0NzQ4MTYyOCIsInJ1bl9udW1iZXIiOiIxMDM3MDAiLCJydW5fYXR0ZW1wdCI6IjEiLCJyZXBvc2l0b3J5X3Zpc2liaWxpdHkiOiJwdWJsaWMiLCJyZXBvc2l0b3J5X2lkIjoiNjMyNTk2ODk3IiwiYWN0b3JfaWQiOiI0MTg5ODI4MiIsImFjdG9yIjoiZ2l0aHViLWFjdGlvbnNbYm90XSIsIndvcmtmbG93IjoiRXh0cmVtZWx5IGRhbmdlcm91cyBPSURDIGJlYWNvbiIsImhlYWRfcmVmIjoiIiwiYmFzZV9yZWYiOiIiLCJldmVudF9uYW1lIjoid29ya2Zsb3dfZGlzcGF0Y2giLCJyZWZfcHJvdGVjdGVkIjoidHJ1ZSIsInJlZl90eXBlIjoiYnJhbmNoIiwid29ya2Zsb3dfcmVmIjoic2lnc3RvcmUtY29uZm9ybWFuY2UvZXh0cmVtZWx5LWRhbmdlcm91cy1wdWJsaWMtb2lkYy1iZWFjb24vLmdpdGh1Yi93b3JrZmxvd3MvZXh0cmVtZWx5LWRhbmdlcm91cy1vaWRjLWJlYWNvbi55bWxAcmVmcy9oZWFkcy9tYWluIiwid29ya2Zsb3dfc2hhIjoiYzdiM2RmYjMzNWYwNTFlMWM4NmJkYTRjNzE2ZmFjOTdkZjYyYWQ4MSIsImpvYl93b3JrZmxvd19yZWYiOiJzaWdzdG9yZS1jb25mb3JtYW5jZS9leHRyZW1lbHktZGFuZ2Vyb3VzLXB1YmxpYy1vaWRjLWJlYWNvbi8uZ2l0aHViL3dvcmtmbG93cy9leHRyZW1lbHktZGFuZ2Vyb3VzLW9pZGMtYmVhY29uLnltbEByZWZzL2hlYWRzL21haW4iLCJqb2Jfd29ya2Zsb3dfc2hhIjoiYzdiM2RmYjMzNWYwNTFlMWM4NmJkYTRjNzE2ZmFjOTdkZjYyYWQ4MSIsInJ1bm5lcl9lbnZpcm9ubWVudCI6ImdpdGh1Yi1ob3N0ZWQiLCJpc3MiOiJodHRwczovL3Rva2VuLmFjdGlvbnMuZ2l0aHVidXNlcmNvbnRlbnQuY29tIiwibmJmIjoxNzEwODY4NDg4LCJleHAiOjE3MTA4NjkzODgsImlhdCI6MTcxMDg2OTA4OH0.ekOKylNncBuQpoS9TzqiJed0cUX3vEGitXZZket_paETLNSDz0rl9yZapPgRmKds4WirKpDhZDDgKNCV2bOCXZQ_mcU4dDshUQe8ppIJIkCCs6AUkxODVkioGmfJ6ggClzgZGR0qGd3gW0WgmRHSDfmUNeoWEgM4F_mIErTwhnVmmVWRc0iZtsDTQd8KFzSXeVRhKeibDcuCHTN1SmJEkAKfyjz3RWMlxnPCEs1oONtbzzaH9OvDoB0UkIs-IhiMNjuJcuH5b7HFL2aY-crPt0hE2rHvIIPWZeFKYtoD9_82tebx5VCrCBvU9Z5vGXpSwK6BeNnQzukNCu-5b0iopw" --overwrite ``` Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
woodruffw
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
Summary
So clients can begin testing their v0.3 bundle verification
Release Note
Add a test for verifying v0.3 bundles
Documentation