Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-requirements: enforce sigstore ~= 2.0 #136

Merged
merged 2 commits into from
Apr 1, 2024
Merged

dev-requirements: enforce sigstore ~= 2.0 #136

merged 2 commits into from
Apr 1, 2024

Conversation

woodruffw
Copy link
Member

This ought to always resolve, but there's nothing preventing pip from selecting an older version without it.

h/t @segiddins

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from jku March 19, 2024 17:02
@woodruffw woodruffw self-assigned this Mar 19, 2024
@woodruffw
Copy link
Member Author

Sigh, I see what happened here:

The conflict is caused by:
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
    The user requested sigstore-protobuf-specs~=0.3.0
    sigstore 2.1.2 depends on sigstore-protobuf-specs~=0.2.2
    The user requested sigstore-protobuf-specs~=0.3.0
    sigstore 2.1.0 depends on sigstore-protobuf-specs~=0.2.2
    The user requested sigstore-protobuf-specs~=0.3.0
    sigstore 2.0.1 depends on sigstore-protobuf-specs~=0.2.0
    The user requested sigstore-protobuf-specs~=0.3.0
    sigstore 2.0.0 depends on sigstore-protobuf-specs~=0.2.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

sigstore-python 2.x is ranged to sigstore-protobuf-specs ~= 0.2, but we've intentionally bumped to ~= 0.3 because of #132. So this fails to resolve a released version of 2.x.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw enabled auto-merge (squash) April 1, 2024 15:06
@woodruffw woodruffw merged commit bab0107 into main Apr 1, 2024
5 checks passed
@woodruffw woodruffw deleted the ww/dev-req branch April 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants