Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner reflection #13

Open
mattia-lecci opened this issue Mar 24, 2021 · 4 comments
Open

Corner reflection #13

mattia-lecci opened this issue Mar 24, 2021 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@mattia-lecci
Copy link
Member

mattia-lecci commented Mar 24, 2021

Problem:
A rare event was found: a corner reflection.
This can only happen for a number of reflection >1, since 2 adjacent triangles are needed.
The problem arises when the MoI identifies a point on the boundaries between the 2 triangles to be the reflection point P.

This creates 2 problems:

  1. Considering, for example, 2 reflections, the identified path will have the following structure: TX -> P -> P -> RX. This creates a sort of "ghost" segment in the middle, which might create bugs somewhere else.
  2. Given the symmetry of this path, reversing the 2 triangles will yield an identical ray. This means that 2 rays will be produced, acting a single one, and thus their power will always add coherently, thus being equivalent to the same ray with double the power (+3 dB).

Solution:
No solution for the moment.
This case should be rare enough to be negligible.
Other programs built on top of this should be aware of this issue and deal with it somehow.

Example case:
Rectangular empty room of size (14, 7, 3).
2 nodes in (1, 3, 1.6) and (1, 9, 1.6), respectively.
Corner reflection on floor and bottom wall, from the visualizer file:
(9, 3, 1.6), (5, 0, 0), (5, 0, 0), (1, 3, 1.6)

Notes:
This problem was found in the treetraversal branch, but the theory should hold in general, and the problem should thus be found in the master branch as well.

@mattia-lecci mattia-lecci added bug Something isn't working wontfix This will not be worked on labels Mar 24, 2021
@neerajvarshney
Copy link

Hi Mattia Thank you for pointing out this.

Could you please share this example folder to resolve this bug?

Best

@mattia-lecci
Copy link
Member Author

Hi Mattia Thank you for pointing out this.

Could you please share this example folder to resolve this bug?

Best

Sure, I'll send it to you via mail!

@neerajvarshney
Copy link

This issue has been resolved!

@mattia-lecci
Copy link
Member Author

This issue has been resolved!

Update: the issue has been resolved in the master branch, but not in feature/treetraversal.

I will keep this issue open as a remainder.

tangnist added a commit to usnistgov/qd-realization that referenced this issue May 13, 2021
New scenarios, bugfix, updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants