Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing Bottom Controls in ImageEditorCropViewController #5976

Open
3 tasks done
ChronicLynx opened this issue Feb 20, 2025 · 0 comments · May be fixed by #5977
Open
3 tasks done

Disappearing Bottom Controls in ImageEditorCropViewController #5976

ChronicLynx opened this issue Feb 20, 2025 · 0 comments · May be fixed by #5977

Comments

@ChronicLynx
Copy link

ChronicLynx commented Feb 20, 2025

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

There appears to be a very rare case where the bottom controls when cropping an image can entirely disappear, leaving you unable to get out of the crop tool without force closing the application. Behavior seems almost like a race condition in that it only happens very rarely and is difficult to reliably reproduce. Somehow the buttons are getting stuck in the hidden state I think, and is related to the transitionUI function.

I've also had this happen with the markup tool which appears to use the same animation methods for the bottom row of buttons.

Steps to reproduce

  • Open and close the crop editor and spam inputs. Really tough to get it to happen. It will naturally happen to me about once a day or every other day.

Actual result: Navigation controls will sometimes be absent, leaving the user unable to exit the crop tool.

Expected result: Navigation controls should ALWAYS be present when in the crop tool. Disabling animations seems to fix this, but I'd like to come up with a solution that preserves the animations and prevents the potential race condition.

Screenshots

Device info

Device: iPhone 16 Pro Max

iOS version: 18.3.1 (and previous releases)

Signal version: 7.47 (625)

Link to debug log

https://debuglogs.org/ios/7.47.0/e321bc0df8a08148136ed43d6dcc607a27ca9f8e02c3db11681d37fd8cc74dd8.zip

This error stands out to me in relation to the issue: 2025/02/20 00:54:25:091 ERR❤️ [AttachmentPrepViewController.swift:221 presentFullScreen(viewController:)]: Already has presented view controller. [<SignalUI.ImageEditorCropViewController: 0x127aef700>]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant