Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13930 - Clamp Large videos to Max duration after Media quality… #13932

Closed
wants to merge 1 commit into from

Conversation

Sagar0-0
Copy link
Contributor

Closes #13930

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This change only clamp the video duration to the max possible duration after a quality change.

Further improvements:
Show a toast(like quality toggle toast) when the video is trimmed, (both while adding a new media and after changing the quality).

Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh interesting, thank you for catching this! Will go out in 7.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Large videos won't be send but throw UndeliverableMessageException
2 participants