Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade message.position to message.place; remove stray console.log #120

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

oscarlevin
Copy link
Contributor

This gets rid of the ts warnings about message.position. It also removes that extra console.log that spit out messages.

@siefkenj siefkenj merged commit 487183d into siefkenj:main Nov 5, 2024
2 checks passed
@siefkenj
Copy link
Owner

siefkenj commented Nov 5, 2024

Thanks!

@oscarlevin oscarlevin deleted the cleanup branch November 5, 2024 16:25
@oscarlevin
Copy link
Contributor Author

In trying to eliminate another type warning at file, I discovered that there are two different VFile imports. Some (in the pretext conversion package) are from "vfile" and others are from "unified-lint-rule/lib". Changing them all to the latter fixes the type error, but introduces other errors. Is there an advantage to cleaning this up? Any prefference?

@siefkenj
Copy link
Owner

siefkenj commented Nov 5, 2024

All imports should be from the same place (and we should keep all versions in sync). If you want to switch so that everybody uses a newer vfile, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants