Improved static cache.

shvetsgroup · Sep 12, 2018 · 13f6082 · 13f6082
1 parent 49814c4
commit 13f6082
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/Controllers/PageController.php b/src/Controllers/PageController.php
@@ -40,9 +40,17 @@ public function show($uri = '/')
             $page = $this->pages->findByUriOrFail($uri);
         }
 
-        request()->route()->setParameter('cache', $page->getAttribute('cache', true));
 
-        return $page->render();
+        $response = response()->make($page->render());
+
+        $cache = $page->getAttribute('cache', true);
+        request()->route()->setParameter('cache', $cache);
+
+        if ($cache) {
+            $response->setPublic()->setMaxAge(60 * 5)->setSharedMaxAge(3600 * 24 * 365);
+        }
+
+        return $response;
     }
 
     /**

diff --git a/src/Middleware/StaticCache.php b/src/Middleware/StaticCache.php
@@ -24,13 +24,6 @@ public function handle($request, Closure $next)
         $staticCache = app('jetpages.staticCache');
         $result = $staticCache->handleRequest($request, $response);
 
-        if ($result && $response->isCacheable()) {
-            if ($response->getMaxAge() === null) {
-                $response->setExpires(new \DateTime("+1 hour"));
-            }
-            $response->setPublic();
-        }
-
         return $response;
     }