Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 error when listing non-orphan visits with short-url-depending API key #2370

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 19, 2025

Closes #2368

Ensure non-orphan visits query joins with short urls if it's going to need to filter by it.

@acelaya acelaya merged commit af2d676 into shlinkio:develop Feb 19, 2025
21 checks passed
@acelaya acelaya deleted the feature/missing-join-fix branch February 19, 2025 18:37
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (766758f) to head (449a588).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2370      +/-   ##
=============================================
+ Coverage      93.79%   93.87%   +0.08%     
- Complexity      1706     1707       +1     
=============================================
  Files            277      277              
  Lines           5912     5915       +3     
=============================================
+ Hits            5545     5553       +8     
+ Misses           367      362       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when calling API to get non-orphan visits
1 participant