Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release.yml workflow file #1609

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix release.yml workflow file #1609

merged 1 commit into from
Jun 18, 2024

Conversation

Redeltaz
Copy link
Contributor

Changes

Fix the release.yml workflow file to also bump new release version in the missing spot

Fixes #1601

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label May 25, 2024
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee May 25, 2024 13:42
@Redeltaz Redeltaz changed the base branch from main to release-v0.13 May 25, 2024 13:49
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2024
@Redeltaz Redeltaz changed the base branch from release-v0.13 to main May 25, 2024 13:49
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 25, 2024
@Redeltaz Redeltaz closed this May 25, 2024
@Redeltaz Redeltaz reopened this May 26, 2024
@Redeltaz
Copy link
Contributor Author

Sorry, I had some struggle with the tags :)

@qu1queee qu1queee requested review from SaschaSchwarze0 and removed request for otaviof and qu1queee June 17, 2024 09:43
SaschaSchwarze0
SaschaSchwarze0 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Jun 17, 2024
@SaschaSchwarze0 SaschaSchwarze0 added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5a55672 into shipwright-io:main Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.14.0
Development

Successfully merging this pull request may close these issues.

[BUG] Automatic release README update needs to be fixed
2 participants
@Redeltaz @SaschaSchwarze0