Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Set spec.source.type as mandatory field #1490

Closed
1 task done
qu1queee opened this issue Feb 8, 2024 · 0 comments · Fixed by #1504
Closed
1 task done

[FEATURE] Set spec.source.type as mandatory field #1490

qu1queee opened this issue Feb 8, 2024 · 0 comments · Fixed by #1504
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Feb 8, 2024

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

use-case

Describe the solution that you would like.

On making source.type mandatory.

The main reason, is that users are not used to define a type(e.g. oci, git), but just the source object definition. In the absence of the type definition, a buildrun will never succeed.

Describe alternatives you have considered.

None

Anything else?

In the future, we could make this something that a mutating webhook could handle(setting the type depending on the source type), changing the proposed behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
2 participants