Legacy formatter: directory now has default value (#24)

* Legacy formatter: directory now has default value * Better default * Fix neon schema * wording
shipmonk-rnd · Dec 13, 2024 · cb4a3e4 · cb4a3e4
1 parent 9907db8
commit cb4a3e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/extension.neon b/extension.neon
@@ -7,10 +7,11 @@ services:
 
 parameters:
     shipmonkBaselinePerIdentifier:
+        directory: null
         indent: '    '
 
 parametersSchema:
     shipmonkBaselinePerIdentifier: structure([
-        directory: string()
+        directory: schema(string(), nullable())
         indent: string()
     ])
diff --git a/src/BaselinePerIdentifierFormatter.php b/src/BaselinePerIdentifierFormatter.php
@@ -29,8 +29,12 @@ class BaselinePerIdentifierFormatter implements ErrorFormatter
 
     private string $indent;
 
-    public function __construct(string $baselinesDir, string $indent)
+    public function __construct(?string $baselinesDir, string $indent)
     {
+        if ($baselinesDir === null) {
+            throw new LogicException('Baselines directory must be set, please set up \'parameters.shipmonkBaselinePerIdentifier.directory\' in your phpstan configuration file');
+        }
+
         $baselinesRealDir = realpath($baselinesDir);
 
         if ($baselinesRealDir === false) {