Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save mm dont show snap install again #8966

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

NeOMakinG
Copy link
Collaborator

Description

Metamask install snap was shown even if the user was checking the checkbox after connection metamask

Issue (if applicable)

closes #8831

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Use a fresh cache app

  • Connect MM
  • Check the checkbox "don't show again snap install"
  • disconnect mm
  • connect mm again, wallet modal should close automatically after connection

Engineering

n/a

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/eddb8a2b-43c9-499d-a598-08d4ea3186d2

@NeOMakinG NeOMakinG requested a review from a team as a code owner March 6, 2025 15:20
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre enabled auto-merge (squash) March 6, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix over insistent MM snaps dialogoue
2 participants