Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring network fees to portals rates #8961

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Mar 6, 2025

Description

Precisely what it says on the box - Portals now returns gas limit on estimate calls (rates), we have a gas oracle for gas price, and the intersection of that is us able to get network fees for Portals rates 🎉

Issue (if applicable)

closes #8822

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • Portals rates now have network fees displayed

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Screenshot 2025-03-06 at 15 25 39 Screenshot 2025-03-06 at 15 24 05

@gomesalexandre gomesalexandre requested a review from a team as a code owner March 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring Portals network fees from API
1 participant