Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dont beat around the fees bush #8953

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Mar 5, 2025

Description

This PR simplifies the fees by only telling users about the bps as a percentage if applicable, on rate click.
While at it:

  • Removes the protocol line items to match mocks

  • Makes limit not expandable (there's effectively nothing remaining)

  • Uses the same rate/gas component for trade confirm as in input for consistency, and ensures no duplicate "Rate" line item

  • Rename "Transaction Fee" to "Network Fees"

  • remove fees line items

  • discuss with @twblack88 where popover/trigger

  • Match rate/gas row with input and remove protocol line item

  • Check all other consumoors (limit, LP, RFOX) have happy UI

Issue (if applicable)

closes #8800

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Spot input and confirm summary looks good
  • Limit input and confirm summary looks good

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/471afcb3-cfdb-4fb9-af0e-8156f5382a1c

@gomesalexandre gomesalexandre changed the base branch from develop to vite-spike March 5, 2025 07:36
@gomesalexandre gomesalexandre marked this pull request as ready for review March 5, 2025 16:42
@gomesalexandre gomesalexandre requested a review from a team as a code owner March 5, 2025 16:42
@gomesalexandre gomesalexandre marked this pull request as draft March 5, 2025 16:58
@gomesalexandre
Copy link
Contributor Author

Converting to draft as there seems to be some misalignment here re:

  • whether we want to use the rate/gas row consistently (seems like consistency is key, as we already use it in input. Proposed by @twblack88 and implemented in this PR, but not part of original designs)
  • or, instead of using the rate/gas row in confirm screen, just have items there, unexpanded. Meaning we'd bring a rate line item (which isn't here in this PR, as the rate/gas row is a drop-in replacement for it)

Happy with whichever solution we go with, though if we go with the second, feels odd to have a rate/gas row in trade input and none in the trade confirm screens, something something consistency? Whichever way we go with, should look the same in both screens IMO.

Base automatically changed from vite-spike to develop March 6, 2025 09:36
[skip ci] wip: wip

feat: almost there

feat: cleanup

fix: link styling

fix: styles
@gomesalexandre gomesalexandre force-pushed the feat_dont_beat_around_the_fees_bush branch from 7914f6c to c0e7f85 Compare March 6, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant