feat: dont beat around the fees bush #8953
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the fees by only telling users about the bps as a percentage if applicable, on rate click.
While at it:
Removes the protocol line items to match mocks
Makes limit not expandable (there's effectively nothing remaining)
Uses the same rate/gas component for trade confirm as in input for consistency, and ensures no duplicate "Rate" line item
Rename "Transaction Fee" to "Network Fees"
remove fees line items
discuss with @twblack88 where popover/trigger
Match rate/gas row with input and remove protocol line item
Check all other consumoors (limit, LP, RFOX) have happy UI
Issue (if applicable)
closes #8800
Risk
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/471afcb3-cfdb-4fb9-af0e-8156f5382a1c