fix: modalType not set on native creation #8952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns
useNativeSuccess
withuseMobileSuccess
, which does set the modalType properly on creation:web/src/components/MobileWalletDialog/routes/CreateWallet/CreateSuccess.tsx
Line 71 in cadb561
This meant that the
modalType
right after creation would either be none (no previous wallet connected) or the one of the previously connected wallet, which could produce a bunch of small bugs,including that one.
After rehydration however, and when the
modalType
was reconciliated, then things worked as they should and users were able to backup their wallet.Issue (if applicable)
closes #8879
Risk
None, this was a blatant bug.
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/1c2f07f1-c7ed-470f-9264-02e39bb7d24b