Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modalType not set on native creation #8952

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

gomesalexandre
Copy link
Contributor

Description

Aligns useNativeSuccess with useMobileSuccess, which does set the modalType properly on creation:

payload: { modalType: KeyManager.Mobile, isMipdProvider: false },

This meant that the modalType right after creation would either be none (no previous wallet connected) or the one of the previously connected wallet, which could produce a bunch of small bugs,
including that one.
After rehydration however, and when the modalType was reconciliated, then things worked as they should and users were able to backup their wallet.

Issue (if applicable)

closes #8879

Risk

High Risk PRs Require 2 approvals

None, this was a blatant bug.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Able to backup wallet after creation without refreshing the page.

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/1c2f07f1-c7ed-470f-9264-02e39bb7d24b

@gomesalexandre gomesalexandre requested a review from a team as a code owner March 4, 2025 18:55
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre merged commit c297ccb into develop Mar 5, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the fix_native_modalType branch March 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot backup wallet right after creation
2 participants