feat: kk desktop migrate #8927

BitHighlander · 2025-02-23T01:10:09Z

Description

This PR moves ShapeShift to align KeepKey onboarding by directing users to download KeepKey Desktop directly instead of the legacy updater app. The update process now automatically delivers the appropriate installer (whether .exe, .dmg, or .AppImage) without requiring users to manually select their platform-specific file. This change keeps users within the ShapeShift experience, preventing confusion that can arise when redirected to the GitHub releases page. Furthermore, it migrates from the legacy updater app, which has experienced reliability issues and contains outdated Zendesk support links. KeepKey Desktop has successfully onboarded KeepKey users into ShapeShift for multiple years and serves as our primary, documented, and supported onboarding flow.

Issue (if applicable)

closes Update KK Updater CTA to KK Dekstop #8946

Risk

Low – Users have been using KeepKey Desktop for onboarding and updates for years. This change only modifies URLs, translations, and update logic, with no impact on transaction protocols or wallet functionalities.

Testing

Connect a new or un-updated KeepKey to view the onboarding/upgrading flow.

KeepKey onboarding is documented at KeepKey Get Started.

Engineering

Verify that the update flow automatically downloads the correct installer for macOS, Windows, and Linux.
Ensure that UI translations are updated to reference KeepKey Desktop rather than the legacy updater.
Confirm that users remain within ShapeShift and are not redirected to external GitHub release pages.

Operations

🏁 My feature is behind a flag and doesn't require operations testing (yet)

For operations, verify that all updated URLs and support links are correctly routed and monitored. Ensure that the transition to KeepKey Desktop is reflected in documentation and communications, and that there are no adverse effects on existing monitoring or support processes.

Screenshots (if applicable)

New Dynamic version downloader

Update flow
any version under latest

Update button now opens modal

toast now opens modal

0xApotheosis

Some thoughts from a first pass:

❌ We are missing CSPs for https://api.github.com/repos/keepkey/keepkey-desktop/releases/latest:

❌ Clicking "Download Desktop App" opens a blank tab

✅ External links in the KeepKey menu and the toast now point to the new desktop version.

❔ The only way I've found to bring up the "Download Updated App" button is to reject the pairing request when connecting the KeepKey. On the happy path when I connect an un-updated KeepKey it just connects as normal.

See Jam showing each of these behaviours: https://jam.dev/c/76684e0d-f199-444e-aff1-c003459d673d

0xApotheosis · 2025-02-24T07:00:35Z

src/assets/translations/de/main.json

@@ -1195,7 +1195,7 @@
        "button": "Nochmaliger Versuch"
      },
      "downloadUpdater": {
-        "header": "Lade den KeepKey-Updater",


These translation changes are probably fine as they are literal English strings, but in files like ja/main.json (and ru, uk etc) we'll want to remove the key so it triggers the globalization workstream to come back and re-translate it.

E.g. KeepKeyアップデーターをダウンロード translates to Download the KeepKey Updater..

Alternatively you could probably reasonably skip the re-translation step and use AI to do it in this PR.

I gave this a shot, I noticed a few of the languages done have the the downloadUpdater field at all id/ko and when I tried to run the script I got. ```➜ web git:(feature-kk-desktop-migrate) ✗ yarn translations:update-path
/Users/highlander/WebstormProjects/web/scripts/translations/updateTranslationPath.ts:12
const splitPreviousPath = previousPath.split('.')
^

TypeError: Cannot read properties of undefined (reading 'split')

0xApotheosis · 2025-02-24T07:44:29Z

.env.base

@@ -146,9 +146,9 @@ REACT_APP_ONRAMPER_API_KEY=pk_prod_01HWMA66BYRB2271G08XDZVVCX
 REACT_APP_YAT_NODE_URL=https://a.y.at

 # Keepkey updater
-REACT_APP_KEEPKEY_UPDATER_RELEASE_PAGE=https://github.com/keepkey/keepkey-updater/releases/latest
+REACT_APP_KEEPKEY_UPDATER_RELEASE_PAGE=https://github.com/keepkey/keepkey-desktop/releases/latest


REACT_APP_KEEPKEY_UPDATER_RELEASE_PAGE isn't actually used anywhere in the app, and I think can actually be removed entirely.

It's imported in src/context/WalletProvider/KeepKey/helpers.ts to no effect.

0xApotheosis · 2025-02-24T07:44:37Z

.env.base

 REACT_APP_KEEPKEY_DESKTOP_URL=http://localhost:1646/
-REACT_APP_KEEPKEY_UPDATER_BASE_URL=https://github.com/keepkey/keepkey-updater/releases/download/v2.1.4/
+REACT_APP_KEEPKEY_UPDATER_BASE_URL=https://github.com/keepkey/keepkey-desktop/releases/download/v3.0.27/


Same with REACT_APP_KEEPKEY_UPDATER_BASE_URL.

0xApotheosis · 2025-02-24T07:45:56Z

react-app-rewired/headers/csps/wallets/keepkey.ts

@@ -4,5 +4,6 @@ export const csp: Csp = {
  'connect-src': [
    process.env.REACT_APP_KEEPKEY_VERSIONS_URL!,
    process.env.REACT_APP_KEEPKEY_DESKTOP_URL!,
+    'https://api.github.com/repos/keepkey/keepkey-desktop/releases/*',


This guy should be an env var.

moved to env.

0xApotheosis · 2025-02-24T07:46:12Z

src/context/WalletProvider/KeepKey/components/DownloadUpdaterApp.tsx

+      try {
+        const resp = await axios({
+          method: 'GET',
+          url: 'https://api.github.com/repos/keepkey/keepkey-desktop/releases/latest',


and then use that env var as the prefix here.

0xApotheosis · 2025-02-24T07:48:41Z

src/context/WalletProvider/KeepKey/components/DownloadUpdaterApp.tsx

+        case 'Linux':
+          return downloadUrls.Linux
+        default:
+          return 'https://github.com/keepkey/keepkey-desktop/releases/latest'


We actually could use REACT_APP_KEEPKEY_UPDATER_RELEASE_PAGE here instead of removing it.

src/context/WalletProvider/KeepKey/components/DownloadUpdaterApp.tsx

… references

BitHighlander · 2025-02-25T05:34:42Z

Thanks for Posting the jam. I modified this pr to handle both the toast and update buttons to open the wallet modal and point to the download page itself. and it should no longer open a new tab and instead keep they on shapeshift and just download.

gomesalexandre · 2025-03-04T11:33:38Z

Superseeded by #8949

BitHighlander requested a review from a team as a code owner February 23, 2025 01:10

BitHighlander changed the title ~~Feature kk desktop migrate~~ feat: kk desktop migrate Feb 23, 2025

0xApotheosis requested changes Feb 24, 2025

View reviewed changes

feat: migrate desktop v3 changes with download functionality

cff4ac7

BitHighlander force-pushed the feature-kk-desktop-migrate branch from 4f61007 to cff4ac7 Compare February 25, 2025 03:28

BitHighlander added 4 commits February 24, 2025 20:47

download flow ux

74ea5ed

Fix KeepKey Desktop download functionality and remove raw.githack.com…

d50992a

… references

remove unused

b43846b

env var migrate

e72f4f6

Merge branch 'develop' into feature-kk-desktop-migrate

ae2a9bf

BitHighlander requested a review from 0xApotheosis February 26, 2025 17:15

gomesalexandre mentioned this pull request Mar 4, 2025

feat: migrate KK updater links to KK desktop #8949

Merged

1 task

gomesalexandre closed this Mar 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: kk desktop migrate #8927

feat: kk desktop migrate #8927

BitHighlander commented Feb 23, 2025 •

edited by gomesalexandre

Loading

0xApotheosis left a comment

0xApotheosis Feb 24, 2025 •

edited

Loading

BitHighlander Feb 25, 2025

0xApotheosis Feb 24, 2025

BitHighlander Feb 25, 2025

0xApotheosis Feb 24, 2025

BitHighlander Feb 25, 2025

0xApotheosis Feb 24, 2025

BitHighlander Feb 25, 2025

0xApotheosis Feb 24, 2025

BitHighlander Feb 25, 2025

0xApotheosis Feb 24, 2025 •

edited

Loading

BitHighlander commented Feb 25, 2025

gomesalexandre commented Mar 4, 2025

feat: kk desktop migrate #8927

feat: kk desktop migrate #8927

Conversation

BitHighlander commented Feb 23, 2025 • edited by gomesalexandre Loading

Description

Issue (if applicable)

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

0xApotheosis left a comment

Choose a reason for hiding this comment

0xApotheosis Feb 24, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xApotheosis Feb 24, 2025 • edited Loading

Choose a reason for hiding this comment

BitHighlander commented Feb 25, 2025

gomesalexandre commented Mar 4, 2025

BitHighlander commented Feb 23, 2025 •

edited by gomesalexandre

Loading

0xApotheosis Feb 24, 2025 •

edited

Loading

0xApotheosis Feb 24, 2025 •

edited

Loading