-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tackle all remaining no-non-null-assertion lint errors #8926
Open
gomesalexandre
wants to merge
16
commits into
develop
Choose a base branch
from
feat_non_null_assert_4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,060
−566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes all remaining offenders of
no-non-null-assertion
so we can finally bring this guy in 🎉Issue (if applicable)
closes #8909
Risk
Technically high because of the number of domains touched, in reality should be fairly low-risk
Technically low, this makes things safer theoretically but effectively medium/high because of the surface area
Testing
Do a full app smoke test focusing on:
Engineering
Operations
Screenshots (if applicable)
Tx history (nuke your cache beforehand to ensure we're parsing everything from scratch)
Fiat ramps
0d891e-91da-4f5c-9c8c-0d53de484d43
Balance charts (including rainbow charts)
https://jam.dev/c/e0b11104-bd5c-473a-909c-98797f2d10ae
https://jam.dev/c/dfd05f2e-62c0-4677-bd13-ad1ca9cdaf04
https://jam.dev/c/e2cb8178-bd00-4110-9fd1-95a426276ed6
https://jam.dev/c/540d9751-7030-47c9-a74b-55d5343cf8f1