-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use vite instead of react-app-rewired #8924
Conversation
Changed Other commits are residual changes to make it work properly Other errors you did mention should be fixed at some points in our flow and not a part of this work as you mentioned, should we create an issue to track them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
What a pull request! It was initially supposed to be a Spike, but spiking something like this is super hard, it's like a coin flip. It took me around 5 hours to figure out that we had no blockers on this.
Here is the steps I did follow:
To be discussed: Do we want to bring back circular dependencies plugin? Because the vite plugin is detecting around 15 more circular dependencies, can be done in a follow up but as discussed with @gomesalexandre we might not care
Issue (if applicable)
closes #8812
Risk
High (Effectively high as we touch absolutely the whole app)
Testing
Smoke test absolutely everything in the app
Engineering
n/a
Operations
n/a
Screenshots (if applicable)
Create and connect native wallet
https://jam.dev/c/f2660871-45bc-48b4-a237-9bafe28a86af
Import native wallet
https://jam.dev/c/4188921f-8ad7-46b0-8895-be6b972d45f9
General test + swap
https://jam.dev/c/9d841328-482c-427e-b716-c256d22ca816
also tested on gome for mobile