feat: swapper no-non-null-asserts #8919
Merged
+236
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
changed the title
gomesalexandre
changed the title
gomesalexandre
force-pushed
the
feat_non_null_assert_2
branch
from
1251799 to
96a26a9
Compare
gomesalexandre
commented
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The same as before, but in swapper.
Note, this does not bring additional actual safety, only runtime safety against exceptions. We should probably do another pass after this gets merged, and convert the naive tackling
to a more carefully thought one, which instead of just ensuring crashes don't happen, allow sub-optimal user states not to happen, either.
Issue (if applicable)
relates to #8909
Risk
Theoretically because it does bring safety. In effect, medium, touches all swapper.
Testing
Engineering
Operations
Screenshots (if applicable)
E2E p1
https://jam.dev/c/f619e639-83e8-4093-b24f-efc2e2fe32b7
E2E p2
https://jam.dev/c/020681d2-4fa2-4347-ba53-b4ffe938e1e3