Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn off swapper thorchain ack flag #8797

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

NeOMakinG
Copy link
Collaborator

Description

Remove thorchain swapper ACK as it's not more stable

Issue (if applicable)

closes #8784

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try a thorchain swap, it shouldn't show an ACK if the swap feels normal!

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/5d3bffdd-b0e7-43f5-94e8-7ed933f4b489

@NeOMakinG NeOMakinG requested a review from a team as a code owner February 11, 2025 14:52
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledgement for THORChain trades is indeed gone with this flag disabled 👌

@0xApotheosis 0xApotheosis merged commit 0d3a2e6 into develop Feb 11, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the swapper-ack-thor branch February 11, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove THORChain swapper ACK
2 participants