chore: make account management toggles use toggle functions instead of setters #6816
+46
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
May 5, 2024
woodenfurniture
force-pushed
the
account-management-modal-5
branch
from
b77cd73 to
c42909b
Compare
woodenfurniture
force-pushed
the
account-toggles-use-toggles
branch
from
fb671b3 to
cb0baa4
Compare
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to make the import accounts drawer use toggle functions instead of setters. No functionality changes with this PR.
NOTE: A bug was identified while implementing this where the toggle state from a previous chain being managed appears on the current one - this will be fixed in a follow-up PR (#6817) as it's unrelated to this.
Pull Request Type
Issue (if applicable)
closes #6815
Risk
Low risk.
Testing
Check account import toggles in the account management drawer functions as it did previously (including the toggle state bug identified above)
Engineering
Operations
Screenshots (if applicable)