-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account management wiring progression #6798
Conversation
6d83dc0
to
831f5d8
Compare
7e89360
to
b77cd73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass comments.
src/components/ManageAccountsDrawer/components/ImportAccounts.tsx
Outdated
Show resolved
Hide resolved
src/components/ManageAccountsDrawer/components/ImportAccounts.tsx
Outdated
Show resolved
Hide resolved
src/components/ManageAccountsDrawer/components/ImportAccounts.tsx
Outdated
Show resolved
Hide resolved
src/components/ManageAccountsDrawer/components/ImportAccounts.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Max's seed and confirmed that this does what it says it does.
Happy with this PR pending your thoughts on the comments above.
src/components/ManageAccountsDrawer/components/ImportAccounts.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally - a few smallish comments, but looks sane at runtime
Import Accounts count looks sane
Note for all of these, the 1*(script types) isn't necessarily true, currently, the accounts (wallet) page does not necessarily reflect it and may be missing accounts. This is a bug currently present on prod and has been captured in #6826.
- Import Accounts count looks sane for BTC (3 script types per account number) ✅

Note the single scriptType for account 1 because of the issue stated above, unrelated to this PR


Accounts per accout number are 3 as expected 🎉
- Adding new accounts correctly add the 1*3 accounts for BTC ✅

- Import Accounts count looks sane for DOGE (1 script type per account number) ✅


The balance being 0 is correct - this account does have a 0-balance, all of its value being DeFi savers value.
- Adding new accounts correctly add the 1*1 accounts for DOGE ✅

- Import Accounts count looks sane for EVM chains (account-based = 1 account) ✅


- Adding new accounts correctly add the 1*1 accounts for EVM chains ✅

- Import Accounts count looks sane for ATOM (account-based = 1 account) ✅
Minus the label issue noted during CR.


- Adding new accounts correctly add the 1*1 accounts for ATOM

Balances are working both for accounts already present, and those that are not yet imported ✅

b77cd73
to
c42909b
Compare
Description
Pull Request Type
Issue (if applicable)
closes #6789
closes #6788
closes #6797
Risk
Low risk.
None of the above.
Testing
Check the account count on the manage accounts modal matches the number of accounts in the import accounts drawer. Note that it's very tricky to tell the difference between in inactive account and an active one if there is zero native asset balance on that account (see below for more info).
Check that all UXTO account types
segwit native
,segwit
,legacy
appear for a given account numberCheck that native asset balances are loaded for accounts that are not auto-added (i.e there is an empty account in between 2 non-empty accounts - you can replicate this by adding 2 new accounts and transferring some coins into the second one - @MBMaria this is already set up on your native wallet for Ethereum). See below for more info.
Engineering
Operations
Screenshots (if applicable)
An ETH account may have some FOX but 0 ETH, so is active:


Similarly, a BTC account may have 0 BTC balance but non-zero thorchain savers balance:


Showing auto-detected accounts up to first empty one (it has 0ETH but has fox, so was detected. the second empty account is actually totally empty). The account after the 2 0ETH accounts has some eth, and the balance is loaded when viewed:
Screen.Recording.2024-05-04.at.10.30.28.AM.mov