Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove eip-1559 related flags from cosmos-sdk trade quote args #6228

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

woodenfurniture
Copy link
Contributor

@woodenfurniture woodenfurniture commented Feb 16, 2024

Description

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6074

Risk

High Risk PRs Require 2 approvals

Moderate impact since it affects trades, though an extremely simple cleanup task and probability of being broken is low.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Check trades from EVM, Cosmos SDK and UTXO assets are working

Engineering

Operations

Screenshots (if applicable)

@woodenfurniture woodenfurniture requested a review from a team as a code owner February 16, 2024 00:14
@woodenfurniture
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@woodenfurniture woodenfurniture changed the title chore: remove eip-1559 related flags from cosmos-sdk trade qutoe args chore: remove eip-1559 related flags from cosmos-sdk trade quote args Feb 16, 2024
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy. Was able to execute swaps with UTXO, EVM and cosmos-based chains πŸ‘Œ

@0xApotheosis 0xApotheosis merged commit cc292f8 into develop Feb 16, 2024
4 checks passed
@0xApotheosis 0xApotheosis deleted the remove-eip1559-cosmos branch February 16, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove supportsEIP1559 from cosmos SDK trade quote args
2 participants