-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basic add liquidity wire-up #6023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
gomesalexandre
commented
Jan 16, 2024
src/pages/ThorChainLP/components/AddLiquitity/components/PoolSummary.tsx
Outdated
Show resolved
Hide resolved
692a4d3
to
edabb4e
Compare
0xApotheosis
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says (can click around) and well implemented. Let's get this in for progress 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a basic wire-up of THORCHain LP add liquidity - also brings the notion of handling sym/asym differently at view-layer time by displaying one or both assets.
Note, this does not yet wire-up the standalone "Add Liquidity" component, which will be slightly different because of the notion of pool selection.
This also does not wire-up amounts, as these will be coming from confirmed/quote from react-query, which we don't have yet.
Your <asset> will be split into a 50:50 exposure to both <asset2> and <asset> upon entering the pool.
Standalone isn't borked and allows selectionNot for this PRPull Request Type
Issue (if applicable)
Risk
None, this isn't live yet, and many things are either unknown or very likely to change here
Testing
Engineering
Operations
Screenshots (if applicable)
Asset asym
RUNE asym
Symmetrical