Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FWH discount makes it look like all shapeshift fees are free #8813

Closed
2 tasks done
MBMaria opened this issue Feb 12, 2025 · 1 comment · Fixed by #8896
Closed
2 tasks done

FWH discount makes it look like all shapeshift fees are free #8813

MBMaria opened this issue Feb 12, 2025 · 1 comment · Fixed by #8896
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Feb 12, 2025

Overview

Once you have claimed FWH, the fee is showing as free in the trade modal, but if you check the fee simulator, if the trade warrants a fee, it is not shown .

References and additional details

Image

Acceptance Criteria

Even if the fee is small, it should be shown and not listed as free

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Feb 12, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 17, 2025
@0xean
Copy link
Contributor

0xean commented Feb 17, 2025

FWH not included in modal explaining discount based on FOX power.

@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Feb 18, 2025
@NeOMakinG NeOMakinG self-assigned this Feb 18, 2025
@NeOMakinG NeOMakinG moved this from In progress to In review in ShapeShift Dashboard Feb 20, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants