Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positive Slippage #8779

Open
3 tasks
twblack88 opened this issue Feb 10, 2025 · 5 comments
Open
3 tasks

Positive Slippage #8779

twblack88 opened this issue Feb 10, 2025 · 5 comments
Assignees
@gomesalexandre
Labels
polish Just a little love needed.

Comments

@twblack88
Copy link
Contributor

Positive slippage is good. We currently hit users with 'any' slippage. We should instead

  • display if there is positive slippage in the swapper card
  • remove the ACK for positive slippage
  • add a callout on trade complete for positive slip
@twblack88 twblack88 added needs design polish Just a little love needed. needs product Requires product input before bounty labels Feb 10, 2025
@NeOMakinG
Copy link
Collaborator

  • Start by removing the ACK
  • Change the text to green

Then wait for the designs

@NeOMakinG NeOMakinG moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 10, 2025
@twblack88 twblack88 mentioned this issue Feb 10, 2025
Open
5 tasks
@twblack88
Copy link
Contributor Author

twblack88 commented Feb 11, 2025 •
edited
Loading

https://www.figma.com/design/VSXdqFlFkBhdcPs2WqJqMo/SWAP-UX?node-id=3884-11384&t=pRqbQKTvvT7rmHUE-11

Got the holistic view here. For completion screen and the slippage upfront. We also mocked the tooltip for positive slippage as well

While mocking this, we realized there is a conversation around how we display rates etc. on trade confirm.

@twblack88 twblack88 mentioned this issue Feb 11, 2025
Open
@twblack88 twblack88 removed needs product Requires product input before bounty needs design labels Feb 17, 2025
@0xean
Copy link
Contributor

0xean commented Feb 17, 2025

  • delaying larger changes to positive slippage flow so we can consider the interaction with FOX holdings and the better rate (fees included in rate work)

@0xean
Copy link
Contributor

0xean commented Feb 17, 2025

Image

Just a note on this: cannot know the positive slippage ahead of time.

@0xean 0xean added the needs product Requires product input before bounty label Feb 17, 2025
@twblack88 twblack88 removed the needs product Requires product input before bounty label Feb 24, 2025
@gomesalexandre gomesalexandre self-assigned this Mar 6, 2025
@gomesalexandre gomesalexandre moved this from Up next / groomed to Blocked in ShapeShift Dashboard Mar 6, 2025
@gomesalexandre
Copy link
Contributor

Moving to blocked until #8800 is disambiguated and we're a stamped state - this will go on top of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
polish Just a little love needed.
Projects
ShapeShift Dashboard
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
4 participants
@twblack88 @NeOMakinG @0xean @gomesalexandre