Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP deposits are being refunded #8740

Closed
2 tasks done
MBMaria opened this issue Feb 4, 2025 · 1 comment · Fixed by #8871
Closed
2 tasks done

LP deposits are being refunded #8740

MBMaria opened this issue Feb 4, 2025 · 1 comment · Fixed by #8871
Assignees
Labels
bug Something isn't working

Comments

@MBMaria
Copy link

MBMaria commented Feb 4, 2025

Overview

Users are getting their LP deposits refunded which appears to be due to a loss of nodes. The can still deposit and are charged gas fees but then the amount is refunded to them

References and additional details

https://viewblock.io/thorchain/tx/1F76192F152379D4D7EB3799D048FCE1DD756D5A70879DD97293A53951AB4524

Acceptance Criteria

Should there be a warning on LPs about potential failed transactions or potentially halt LPs deposits until the nodes are sorted?

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added needs engineering Requires engineering input before bounty needs product Requires product input before bounty labels Feb 4, 2025
@0xean
Copy link
Contributor

0xean commented Feb 17, 2025

Add warning / ack to flow to let users know about current state. Better to not disable entirely, just let users proceed at own risk

@0xean 0xean added bug Something isn't working and removed needs engineering Requires engineering input before bounty needs product Requires product input before bounty labels Feb 17, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 17, 2025
@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Feb 18, 2025
@NeOMakinG NeOMakinG self-assigned this Feb 18, 2025
@NeOMakinG NeOMakinG moved this from In progress to In review in ShapeShift Dashboard Feb 18, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants