Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action bar, Routes vs modals #8714

Open
twblack88 opened this issue Feb 1, 2025 · 2 comments
Open

Action bar, Routes vs modals #8714

twblack88 opened this issue Feb 1, 2025 · 2 comments
Labels
needs product Requires product input before bounty polish Just a little love needed.

Comments

@twblack88
Copy link
Contributor

twblack88 commented Feb 1, 2025

Somewhat inconsistent to have modals and routes. "Send", "Receive" and "Scan QR Code" are modals, "Trade or Bridge" and "Buy and sell" are routes - feels weird and inconsistent when swapping between them. I.e. some I have to close by swiping down/pressing "x", for others I still have the menu bar.

@twblack88 twblack88 added the polish Just a little love needed. label Feb 2, 2025
@NeOMakinG
Copy link
Collaborator

NeOMakinG commented Feb 10, 2025

TLDR: All the actions modals should be a drawer like the new wallet flow (we can change the modal to the Dialog component)

Also test the features please

⚠ be careful with this because the Drawer has a few weird behavior with zIndexes/focus traps

@NeOMakinG NeOMakinG moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 10, 2025
@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Feb 13, 2025
@NeOMakinG NeOMakinG self-assigned this Feb 13, 2025
@NeOMakinG
Copy link
Collaborator

I think, we can't without a big lift because routing is used to prepopulate asset from swapper/fiat ramp

@shapeshift/product do we want to close this issue or do we need something else? Every other actions are already modals

@NeOMakinG NeOMakinG removed their assignment Feb 14, 2025
@NeOMakinG NeOMakinG moved this from In progress to Blocked in ShapeShift Dashboard Feb 14, 2025
@NeOMakinG NeOMakinG added the needs product Requires product input before bounty label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product Requires product input before bounty polish Just a little love needed.
Projects
Status: Blocked
Development

No branches or pull requests

2 participants