Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepKey PayToTaproot (P2TR) Support #8374

Open
gomesalexandre opened this issue Dec 16, 2024 · 4 comments
Open

KeepKey PayToTaproot (P2TR) Support #8374

gomesalexandre opened this issue Dec 16, 2024 · 4 comments
Assignees
@gomesalexandre

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Dec 16, 2024 •
edited by 0xean
Loading

Overview

This is a placeholder as a duplicate of #8277 - effectively the exact same issue of sending to Taproot not working for KeepKey atm, but duplicating it so we can link this to affected users.

References and additional details

N/A

Acceptance Criteria

  • P2TR sends are working with KeepKey when the KK is on version > 7.10.0
  • Version checks for KK are buggy, so assume KK users is on latest version

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@gomesalexandre
Copy link
Contributor Author

@0xean to be moved to the board since word of mouth is KK P2TR is making it next KK fw release: https://discord.com/channels/554694662431178782/554694662896615436/1327799275228500039
Can't see anything related to it (nor any activity for months for that matter) in https://github.com/keepkey/keepkey-firmware but...

@gomesalexandre
Copy link
Contributor Author

Note: things should work OOTB when supported at firmware-level, revert #8506 and sanity retest it indeed works.

@0xean
Copy link
Contributor

0xean commented Jan 13, 2025

thanks for staying on top of this and we can groom today.

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 13, 2025
@gomesalexandre gomesalexandre self-assigned this Jan 24, 2025
@gomesalexandre gomesalexandre moved this from Up next / groomed to Blocked in ShapeShift Dashboard Jan 24, 2025
@gomesalexandre
Copy link
Contributor Author

maybe? keepkey/keepkey-firmware@d54797e

@0xean 0xean removed the blocked label Mar 2, 2025
@0xean 0xean moved this from Blocked to Up next / groomed in ShapeShift Dashboard Mar 2, 2025
@gomesalexandre gomesalexandre mentioned this issue Mar 4, 2025
Open
1 task
@gomesalexandre gomesalexandre moved this from Up next / groomed to In review in ShapeShift Dashboard Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
None yet
Projects
ShapeShift Dashboard
Status: In review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @gomesalexandre