Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spike] Approval flow for cow limits #6204

Closed
0xean opened this issue Feb 13, 2024 · 2 comments
Closed

[Spike] Approval flow for cow limits #6204

0xean opened this issue Feb 13, 2024 · 2 comments
Assignees
@woodenfurniture
Labels
limit orders

Comments

@0xean
Copy link
Contributor

0xean commented Feb 13, 2024 •
edited
Loading

  • spike into permit2 for cowswap (create payload and attach payload to order?)
  • output from spike is ticket to be groomed
@twblack88 twblack88 moved this from Backlog to Blocked in ShapeShift Dashboard Mar 21, 2024
@0xean 0xean removed the status in ShapeShift Dashboard Oct 10, 2024
@0xean 0xean changed the title Approval flow and balance checks for limit orders [Spike] Approval flow for cow limits Oct 10, 2024
@woodenfurniture woodenfurniture self-assigned this Nov 20, 2024
@woodenfurniture
Copy link
Contributor

Permit2 is not available for cowswap, but they do provide EIP-2612 Permit, which requires a token that has EIP-2612 permit support (such as COW, USDC, and DAI - many tokens do not support this.

To avoid the complexity of multiple allowance flows for cow limit orders, I recommend we stick to vanilla ERC20 approve().

@woodenfurniture woodenfurniture moved this from In review to In progress in ShapeShift Dashboard Nov 20, 2024
@woodenfurniture woodenfurniture changed the title [Spike] Approval flow for cow limits Approval flow for cow limits Nov 20, 2024
@woodenfurniture woodenfurniture changed the title Approval flow for cow limits [Spike] Approval flow for cow limits Nov 20, 2024
@woodenfurniture woodenfurniture mentioned this issue Nov 20, 2024
Closed
@woodenfurniture
Copy link
Contributor

Closing, outcomes in ticket #8154

@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
limit orders
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @woodenfurniture