Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined BPS in swapper confirm trade screen #6160

Closed
0xean opened this issue Feb 8, 2024 · 1 comment · Fixed by #6163
Closed

Undefined BPS in swapper confirm trade screen #6160

0xean opened this issue Feb 8, 2024 · 1 comment · Fixed by #6163
Assignees
Labels
bug Something isn't working

Comments

@0xean
Copy link
Contributor

0xean commented Feb 8, 2024

Overview

When using cowswap to trade in an account that has sufficient FOX the the trade to be free the text shows undefined bps
Screenshot 2024-02-08 at 7 26 52 AM

References and additional details

Repro:

  1. connect EVM wallet
  2. attempt to swap (using cowswap, may or may not matter)
  3. in the confirm trade modal see that fee BPS when you have fox power and the fee is free

Acceptance Criteria

fee is never undefined

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xean
Copy link
Contributor Author

0xean commented Feb 8, 2024

curious if this could actually mean there is a larger issue with fee calcs and we aren't correctly collecting some fees?

@0xean 0xean added the bug Something isn't working label Feb 8, 2024
@0xean 0xean moved this from To schedule to Up next in ShapeShift Dashboard Feb 8, 2024
@gomesalexandre gomesalexandre self-assigned this Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Up next to Done in ShapeShift Dashboard Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants