Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming swaps completion state errors #6086

Closed
0xean opened this issue Jan 25, 2024 · 5 comments · Fixed by #6143
Closed

Streaming swaps completion state errors #6086

0xean opened this issue Jan 25, 2024 · 5 comments · Fixed by #6143
Assignees
Labels
bug Something isn't working

Comments

@0xean
Copy link
Contributor

0xean commented Jan 25, 2024

summary

When attempting a streaming swap from an EVM to BTC after the initial EVM input transaction was confirmed, the UI showed as Trade Completed / BTC is now in your wallet and the progress bar was still spinning. Even after the BTC was confirmed the progress bar still didn't update.

This was not correct and was much too fast for the outgoing BTC tx to have already been executed.

Will ask operations to recreate and record screen.

Recreation steps

  1. swap BNB or other evm asset to BTC via streaming swap
  2. when BNB tx confirms UI will update to a trade complete state incorreclty

Acceptance Criteria

  • Trade complete only shown when outgoing tx is confirmed
  • progress bar is updated appropriately

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xean 0xean added the bug Something isn't working label Jan 25, 2024
@0xean 0xean moved this from To schedule to Up next in ShapeShift Dashboard Jan 25, 2024
@purelycrickets
Copy link

Ops was able to recreate and screen record this issue as described above.

See the successful "Trade complete Successfully received BTC on Bitcoin" message while the outbound BTC has been sent on chain:

Screen.Recording.2024-01-26.at.11.19.16.AM.mov

@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Jan 31, 2024
@woodenfurniture
Copy link
Contributor

woodenfurniture commented Feb 1, 2024

Ops was able to recreate and screen record this issue as described above.

See the successful "Trade complete Successfully received BTC on Bitcoin" message while the outbound BTC has been sent on chain:

Screen.Recording.2024-01-26.at.11.19.16.AM.mov

@purelycrickets is this the correct screen recording? it seems to be cut short

@purelycrickets
Copy link

Whoops, that was my failed first attempt at recording it. Here is the actual error recorded:
Uploading Screen Recording 2024-01-26 at 11.19.52 AM.mov…

@purelycrickets
Copy link

lol here it is:

Screen.Recording.2024-01-26.at.11.19.52.AM.mov

@woodenfurniture
Copy link
Contributor

@purelycrickets that one's a regular thorchain swap. Judging by the BTC showing as received in dropdown at the top of our app (which is totally disjoint to the swapper and runs off blockbook), it the looks the funds were in fact received and it seems the mismatch between us and viewblock is indexing on their viewblock's side - i.e they can take several minutes longer than us to index and display a completed trade. I dont think there is an issue with regular swaps at least.

Do we have a recording of the streaming swap issue regarding progress bar not updating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants