Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure swappers report when cross-account trades are not supported #6075

Closed
woodenfurniture opened this issue Jan 24, 2024 · 0 comments
Closed
Assignees

Comments

@woodenfurniture
Copy link
Contributor

Overview

When we the user inputs a cross-account trade we used to show a "Cross-account trade not supported" or similar error message on the swapper, still showing the swapper. We no longer do (e.g. we'll never see 0x show up if another receive account is selected.

References and additional details

#6051 (comment)

Acceptance Criteria

Ensure swappers report a trade quote error so its known to the user when cross account trades are not supported by a specific swapper.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@woodenfurniture woodenfurniture self-assigned this Jan 24, 2024
@woodenfurniture woodenfurniture moved this from To schedule to Up next in ShapeShift Dashboard Feb 8, 2024
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Feb 15, 2024
@0xean 0xean closed this as completed Feb 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants