Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove supportsEIP1559 from cosmos SDK trade quote args #6074

Closed
woodenfurniture opened this issue Jan 24, 2024 · 0 comments · Fixed by #6228
Closed

Remove supportsEIP1559 from cosmos SDK trade quote args #6074

woodenfurniture opened this issue Jan 24, 2024 · 0 comments · Fixed by #6228
Assignees
@woodenfurniture

Comments

@woodenfurniture
Copy link
Contributor

Overview

Inside src/components/MultiHopTrade/hooks/useGetTradeQuotes/getTradeQuoteArgs.ts the cosmos SDK case includes supportsEIP1559 which is invalid. Refactor so this isnt the case.

References and additional details

#6051 (comment)

Acceptance Criteria

Cosmos SDK trade quote args should not include EVM specific arguments

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@woodenfurniture woodenfurniture self-assigned this Jan 24, 2024
@woodenfurniture woodenfurniture mentioned this issue Jan 24, 2024
Merged
3 tasks
@woodenfurniture woodenfurniture moved this from To schedule to Up next in ShapeShift Dashboard Feb 8, 2024
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Feb 15, 2024
@woodenfurniture woodenfurniture moved this from In progress to In review in ShapeShift Dashboard Feb 16, 2024
@woodenfurniture woodenfurniture mentioned this issue Feb 16, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
None yet
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove eip-1559 related flags from cosmos-sdk trade quote args shapeshift/web
1 participant
@woodenfurniture