You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently v7 farming has expired, while we still need to allow users to interact with this contract to remove assets, it shouldn't show any APY.
The staking contracts have an expiration date that is build into them (periodFinish) which should be respected as the deadline to no longer show a valid APR on the staking contract.
Not sure how this has been dealt with in the past, but ideally we simply query that timestamp to disable showing any rewards past the date.
Acceptance Criteria
UI correctly stops showing rewards/APR for a staking contract after periodFinish has past
User can still interact with existing staked position in that contract, but we disable new deposits (think this already exists).
bonus points if we display the expiration date nicely somewhere in the UI so that the user understands the timeline and when they will need to migrate (next to V8 or the APR, maybe @reallybeard has an opinion as to where)
alternative long-term solution: we find a better staking contract to fork and stop with this nonsense every 4.5 months :)
The text was updated successfully, but these errors were encountered:
per conversation with most TMDC members, a new contract would be the desired long term path, so any fixes will just be for v8 and once v8 ends, we will migrate to an evergreen type contract to avoid migrations.
I'll author a PR to ensure we holistically stop showing APR for expired opportunities. While FOX Farming is the obvious one, and the only one having this property, it may not be in the future so might as well!
Currently v7 farming has expired, while we still need to allow users to interact with this contract to remove assets, it shouldn't show any APY.
The staking contracts have an expiration date that is build into them (periodFinish) which should be respected as the deadline to no longer show a valid APR on the staking contract.
Not sure how this has been dealt with in the past, but ideally we simply query that timestamp to disable showing any rewards past the date.
Acceptance Criteria
periodFinish
has pastalternative long-term solution: we find a better staking contract to fork and stop with this nonsense every 4.5 months :)
The text was updated successfully, but these errors were encountered: