Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging/alert for not enough native token gas for amounts close to max #6047

Closed
purelycrickets opened this issue Jan 18, 2024 · 5 comments
Closed
Assignees
Labels
low priority needs product Requires product input before bounty

Comments

@purelycrickets
Copy link

Overview

Currently in production, when selecting an amount that is close to, but not the max amount of an asset a user gets not enough ASSET.ASSET for gas.

Sending some amount less than very close to the available balance will result in a successful trade (if it is above the minimum)

Displaying to the User an amount of balance, and then not allowing them to interact with the balance in full has caused support tickets and a bad user experience for those transacting in small amounts and wishing to use their full balances in any transaction.

References and additional details

Screen.Recording.2024-01-18.at.1.28.48.PM.mov

Acceptance Criteria

Could we possibly allow a user to send all of their balance and subtract the gas after they have selected the full amount?

Man this feels like a feature request for Send Max.

Still gonna keep it as a ticket.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@woodenfurniture
Copy link
Contributor

This very use case was conflated with the "max" button functionality which ended up as a Rube Goldberg machine that had to fetch multiple quotes for a given swapper:

  • one to determine the fees
  • another to determine the quote using the input amount minus the fees from the previous quote

The issue is that network fee fluctuations were causing trade failures. We added a multiplier on the fee to allow for some fluctuations but it always meant balance was left over in the account, hence "send most" meme in product discussions.

I strongly recommend we avoid this

@twblack88
Copy link
Contributor

The learning was send max for native assets on native chains wasn't a fixable loop.

@0xean
Copy link
Contributor

0xean commented Jan 18, 2024

Man this feels like a feature request for Send Max.

if it walks like a duck...

@0xean 0xean added needs product Requires product input before bounty and removed needs engineering Requires engineering input before bounty labels Jan 22, 2024
@0xean
Copy link
Contributor

0xean commented Jan 22, 2024

per conversation on 1-22-24 product will look at error messagin to other UX to help user undertand

@twblack88 twblack88 changed the title Not enough gas error for amounts close to the max amount Messaging/alert for not enough native token gas for amounts close to max May 13, 2024
@twblack88
Copy link
Contributor

Hah, the ole send max of native asset. I think the solution is, sadly, none.

  1. Operations writes a nice macro with product to explain why we're different. Decentralized and multiple quotes. Inherently, we can't tell you the max of the native token minus the quote until we...have the quote.
  2. Closing because this can't really solve with UX and messaging.

From the product lens it should "just work" aka it gives you the maximum amount when you click on it. We could get creative with optimistic quoting if we have one protocol but we have like 4 swappers and will add more too.

@github-project-automation github-project-automation bot moved this from Backlog to Done in ShapeShift Dashboard Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority needs product Requires product input before bounty
Projects
Status: Done
Development

No branches or pull requests

4 participants