Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KK wallet total incorrect #6038

Closed
2 tasks done
MBMaria opened this issue Jan 18, 2024 · 3 comments · Fixed by #6494
Closed
2 tasks done

KK wallet total incorrect #6038

MBMaria opened this issue Jan 18, 2024 · 3 comments · Fixed by #6494
Assignees
Labels
bug Something isn't working

Comments

@MBMaria
Copy link

MBMaria commented Jan 18, 2024

Overview

The wallet value in KK is not correct

References and additional details

  1. log into app.shapeshift and connect to Keepkey
  2. Navigate to wallet page and not the total value for the wallet
    3( Select the wallet tab and not that the assets totals are more than the value listed at the top
    image
Keepkey.wallet.balance.mp4

Acceptance Criteria

Total balance should be an accurate representation of the value of the wallet

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@0xean 0xean added the bug Something isn't working label Jan 18, 2024
@twblack88 twblack88 moved this from To schedule to Up next in ShapeShift Dashboard Mar 11, 2024
@gomesalexandre gomesalexandre self-assigned this Mar 19, 2024
@gomesalexandre
Copy link
Contributor

@0xApotheosis going to take a look at this guy as well

@gomesalexandre
Copy link
Contributor

Note this doesn't seem isolated to KK, see develop native (with AVAX balances) vs. KeepKey
image

@gomesalexandre
Copy link
Contributor

@MBMaria unfortunately this is the same issue we've had just about forever, cannot get the math right here no matter what.

The wallet total excludes earns dupes (and doesn't include staking opportunities), while the chains/accounts balances include both staking earn opportunities and earn dupes (duplicates from earn/wallet i.e FOX and FOXy).

We can probably make this some better by not including staking opportunities in the chain rows either, however the math will still be off one way or another.

With your particular wallet however, the math seems particularly off as you should see it either in wallet or DeFi somehow - is the missing value coming from DeFi opportunities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants
@0xean @gomesalexandre @0xApotheosis @MBMaria and others