Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Below minimum warning triggering on trade values above the minimum warning #6037

Closed
purelycrickets opened this issue Jan 17, 2024 · 1 comment · Fixed by #6044
Closed

Below minimum warning triggering on trade values above the minimum warning #6037

purelycrickets opened this issue Jan 17, 2024 · 1 comment · Fixed by #6044
Assignees
Labels
bug Something isn't working high-priority needs engineering Requires engineering input before bounty

Comments

@purelycrickets
Copy link

Overview

When entering a larger trade size above the thorchain minimum, the minimum red loose your money warning triggers on amounts much higher than the minimum (all amount sizes.

This issue was able to be recreated on ETH and BTC amounts.

If Users could loose funds on all trade sizes, this is a prod issue and thorchain trades need to be flagged off immediately.

References and additional details

See loose your money warning on amounts safely over the minimum:

Screen_Recording_2024-01-17_at_4.36.11_PM.1.mov
Screen_Recording_2024-01-17_at_4.36.11_PM.mov

Acceptance Criteria

Warnings trigger only when users could loose funds.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@purelycrickets
Copy link
Author

Test trades above the minimum completed successfully, so this issue is a UI issue, and not a prod issue.

@purelycrickets purelycrickets added the needs engineering Requires engineering input before bounty label Jan 18, 2024
@0xean 0xean added the bug Something isn't working label Jan 18, 2024
@gomesalexandre gomesalexandre self-assigned this Jan 18, 2024
@github-project-automation github-project-automation bot moved this from To schedule to Done in ShapeShift Dashboard Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants