Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet connect out on mobile not working #6008

Closed
2 tasks done
MBMaria opened this issue Jan 16, 2024 · 6 comments
Closed
2 tasks done

Wallet connect out on mobile not working #6008

MBMaria opened this issue Jan 16, 2024 · 6 comments
Assignees
Labels
needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Jan 16, 2024

Overview

When trying to connect to Idle Finance from the mobile app, the camera doesn't read the QR code and cannot connect

References and additional details

  1. Open mobile app
  2. Select connect dApp from the menu
  3. Try scan the QR code from Idle finance https://app.idle.finance/#/dashboard
  4. Note that the camera in the app does not read the qr code
    *can connect to uniswap by scanning the QR code

Acceptance Criteria

Should be able to connect to idle finance via mobile dApp

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@0xean 0xean added the bug Something isn't working label Jan 16, 2024
@MBMaria
Copy link
Author

MBMaria commented Feb 27, 2024

Unable to connect to any dApps now, including uniswap. dApps are working on desktop but not mobile.

@MBMaria
Copy link
Author

MBMaria commented Feb 27, 2024

  1. open mobile app
  2. select Connect dApp from the top left hand corner menu
  3. scan or enter qr code of desired dApp
  4. Note that the Connect button is a dead click
    image

@0xean 0xean changed the title Unable to connect to Idle finance dApp on mobile app Wallet connect out on mobile not working Feb 28, 2024
@0xean 0xean moved this from To schedule to Up next in ShapeShift Dashboard Feb 28, 2024
@gomesalexandre gomesalexandre self-assigned this Mar 5, 2024
@gomesalexandre gomesalexandre moved this from Up next to Blocked in ShapeShift Dashboard Mar 5, 2024
@gomesalexandre
Copy link
Contributor

Moving to blocked as this is mobile app specific with no errors in sight - debugging this with the iOS debugger would cost at least a day of eng. time

@0xean
Copy link
Contributor

0xean commented Mar 6, 2024

I can take a look at it

@0xean 0xean assigned 0xean and unassigned gomesalexandre Mar 6, 2024
@0xean
Copy link
Contributor

0xean commented Mar 8, 2024

per @woodenfurniture - this never worked and was a known gap when WC shipped.

Therefore we should treat this as a feature request vs a bug ticket and @twblack88 can deliberate on priority.

If we aren't going to add this support to the mobile app, we should remove it from the UI so its not confusing users however.

Some notes if we decide to try and get this working:

@gomesalexandre and I tried updating packages and using the native reach shims from WC... none of this helped. When logging state from the mobile app, the following line is never hit

972d510#diff-cc45a3456fb6eeae871d41a5dd230bf278754ee5a2050b4895833461a61ebd70R42

leading to pair being undefined

972d510#diff-066cc2d15263e61b3f2b227a3ac5742a7fb88c52bb1e2ba9d60d014d44d9d7a0R25

and

972d510#diff-cc45a3456fb6eeae871d41a5dd230bf278754ee5a2050b4895833461a61ebd70R51

always being false.

@0xean 0xean removed the bug Something isn't working label Mar 8, 2024
@NeOMakinG
Copy link
Collaborator

Reopen if I'm wrong but I think we can close this one as it's a part of the new mobile release we've done

@github-project-automation github-project-automation bot moved this from Blocked to Done in ShapeShift Dashboard Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

No branches or pull requests

4 participants