Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM affiliate fees for trade from keepkey not being received #5988

Closed
woodenfurniture opened this issue Jan 11, 2024 · 0 comments · Fixed by #6004
Closed

EVM affiliate fees for trade from keepkey not being received #5988

woodenfurniture opened this issue Jan 11, 2024 · 0 comments · Fixed by #6004
Assignees
Labels
bug Something isn't working

Comments

@woodenfurniture
Copy link
Contributor

woodenfurniture commented Jan 11, 2024

Overview

Currently we have affiliate fees disabled for keepkey EVM trades due to a reported issue in receiving the fees. Its not confirmed whether this is still and issue or what the root cause of the issue would be.

Test EVM trades made from keepkey and check that the fees are being received as intended.

References and additional details

Contact 0xFBL for access to a 0x api so we can analyse a tx and the affiliate fee.

Also see original issue #4518

Acceptance Criteria

  1. Re-check whether affiliate fees are being received on keepkey EVM trades
  2. If fees are being processed as intended, keep them enabled
  3. Otherwise, the high-level root cause should be known (hd-wallet, firmware etc)

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@woodenfurniture woodenfurniture added the bug Something isn't working label Jan 11, 2024
@woodenfurniture woodenfurniture self-assigned this Jan 11, 2024
@woodenfurniture woodenfurniture moved this from To schedule to In progress in ShapeShift Dashboard Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant