feat: prevent non main market bets for bet bonus grant

sge-network · Apr 7, 2024 · b423944 · b423944
1 parent 80bce18
commit b423944
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/x/reward/keeper/msg_server_reward_test.go b/x/reward/keeper/msg_server_reward_test.go
@@ -690,6 +690,9 @@ func TestMsgApplyBetBonus(t *testing.T) {
 		Amount:    sdkmath.NewInt(301),
 		Result:    bettypes.Bet_RESULT_LOST,
 		Status:    bettypes.Bet_STATUS_SETTLED,
+		Meta: bettypes.MetaData{
+			IsMainMarket: true,
+		},
 	}
 	tApp.BetKeeper.SetBet(ctx, bet, 1)
 

diff --git a/x/reward/types/reward_bet_bonus.go b/x/reward/types/reward_bet_bonus.go
@@ -79,6 +79,10 @@ func (sur BetBonusReward) Calculate(goCtx context.Context, ctx sdk.Context, keep
 		return RewardFactoryData{}, sdkerrors.Wrapf(sdkerrtypes.ErrInvalidRequest, "bet not found with uid %s", payload.BetUID)
 	}
 
+	if !bet.Meta.IsMainMarket {
+		return RewardFactoryData{}, sdkerrors.Wrapf(sdkerrtypes.ErrInvalidRequest, "bet bonus grant is allowed for main market bets only %s", payload.BetUID)
+	}
+
 	if bet.Result != bettypes.Bet_RESULT_LOST &&
 		bet.Result != bettypes.Bet_RESULT_WON {
 		return RewardFactoryData{}, sdkerrors.Wrapf(sdkerrtypes.ErrInvalidRequest, "bet should be winner or loser, requested bet result is %s", bet.Result)
@@ -87,11 +91,9 @@ func (sur BetBonusReward) Calculate(goCtx context.Context, ctx sdk.Context, keep
 	effectiveBetAmount := sdk.NewDecFromInt(bet.Amount)
 	if campaign.Constraints != nil {
 		if !campaign.Constraints.MaxBetAmount.IsNil() && campaign.Constraints.MaxBetAmount.GT(sdkmath.ZeroInt()) {
-			if bet.Meta.IsMainMarket {
-				effectiveBetAmount = sdk.NewDecFromInt(
-					sdkmath.MinInt(campaign.Constraints.MaxBetAmount, bet.Amount),
-				)
-			}
+			effectiveBetAmount = sdk.NewDecFromInt(
+				sdkmath.MinInt(campaign.Constraints.MaxBetAmount, bet.Amount),
+			)
 		}
 	}