-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
from PR #264 (@remcom): ruff format and ruff check --fix and some mypy/pylint e… #265
Conversation
…lint erros and fix PR sfstar#264 and fix issues sfstar#259, sfstar#261
I did not check the code but it seems to work on my HAOS instance on the newest beta. |
No problem @jwillmer. I'm up for maintaining this integration. Also want to process/address a lot of other PR's and issue's from this repo. There are some good things in there that i would also look to use. If @julesxxl want to join i can give you access to the repo to. Hopefully i have the new repo up in the coming week when i'm back from holiday again |
Hi all! Because this repo is maintained and i also like to use my Victron equipment in HA i made a new repo that you can use: https://github.com/remcom/hass-victron My goals: process a lot of the outstanding pr's on this repo |
Cool ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version from julesxxl works perfectly for me
Thank you for opening this PR and sorry for the late interaction. This change will ensure that the integration works with 2025.1 or higher due to the pymodbus incompatibility between versions |
from PR #264: ruff format and ruff check --fix and some mypy/pylint erros and fix PR #264 and fix issues #259, #261