Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from PR #264 (@remcom): ruff format and ruff check --fix and some mypy/pylint e… #265

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

julesxxl
Copy link
Collaborator

from PR #264: ruff format and ruff check --fix and some mypy/pylint erros and fix PR #264 and fix issues #259, #261

@devilmastah
Copy link

I did not check the code but it seems to work on my HAOS instance on the newest beta.

@jwillmer
Copy link

jwillmer commented Jan 5, 2025

Thank you for the pull request @remcom and @julesxxl. Everything works again. @julesxxl are u open to continue the support for this integration? Just want to know if this was a one time PR or you will continue to keep the integration running ;-)

@remcom
Copy link
Collaborator

remcom commented Jan 5, 2025

No problem @jwillmer. I'm up for maintaining this integration. Also want to process/address a lot of other PR's and issue's from this repo. There are some good things in there that i would also look to use. If @julesxxl want to join i can give you access to the repo to.

Hopefully i have the new repo up in the coming week when i'm back from holiday again

@remcom
Copy link
Collaborator

remcom commented Jan 5, 2025

Hi all! Because this repo is maintained and i also like to use my Victron equipment in HA i made a new repo that you can use: https://github.com/remcom/hass-victron

My goals:

process a lot of the outstanding pr's on this repo
have a look at the open issues here
code cleanup
Adding support for the new Victron features that are added in the last months
Feel free to make your own pr's on the new branch or make issues on stuff you running into. Also if there are fellow maintainers that want to join please send me a message

@julesxxl
Copy link
Collaborator Author

julesxxl commented Jan 7, 2025

No problem @jwillmer. I'm up for maintaining this integration. Also want to process/address a lot of other PR's and issue's from this repo. There are some good things in there that i would also look to use. If @julesxxl want to join i can give you access to the repo to.

Hopefully i have the new repo up in the coming week when i'm back from holiday again

Cool !

Copy link

@etofi etofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version from julesxxl works perfectly for me

@sfstar
Copy link
Owner

sfstar commented Jan 27, 2025

Thank you for opening this PR and sorry for the late interaction.
For now I will merge this PR pending further discussions regarding the future of this repository.

This change will ensure that the integration works with 2025.1 or higher due to the pymodbus incompatibility between versions

@sfstar sfstar merged commit 787f68f into sfstar:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants