Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when active text editor does not belong to any of the workspace folders of a multiroot workspace #38

Conversation

bjrmatos
Copy link
Contributor

@bjrmatos bjrmatos commented Aug 4, 2022

Overview

When you have a multiroot workspace and the active text editor is something that does not belong to any of the workspace folders (like when you open a file directly from your desktop) you get an error Explorer Exclude: Workspace Folder Not Found. Open Folder or Workspace and try again.

Reviewer

Where should the reviewer start? How to Test? Background Context? etc ( required )

  1. Open a vscode window with a multiroot workspace
  2. Open the file from your desktop (like a markdown file)
  3. Reload the window
  4. Wait until vscode finish to startup and you should not see any error now.

Checklist

I have tested each of the following, and they work as expected: ( required )

  • Meets Contributing Guide Requirements
  • Pulled in the Latest Code from the develop branch
  • Works on a Desktop / Laptop Device

Documentation

Screenshots, Attachments, Linked GitHub Issues, etc ( optional )

fixes #37

What GIF best describes this PR or how it makes you feel?

great

…elong to any of the folders of a multiroot workspace
@bjrmatos
Copy link
Contributor Author

bjrmatos commented Aug 4, 2022

seems i missed to add the Ready for Code Review tag, but I don't see how to update it now, anyway hope you see this fix 😁

@manifestinteractive
Copy link
Member

Man, I keep finding new ways that Workspace messes things up for people. I will get a release out for this today with your fix :)

@manifestinteractive manifestinteractive merged commit cc0dec5 into sfccdevops:develop Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when active text editor does not belong to any of the workspace folders of a multiroot workspace
2 participants