Fix squiggle in a user's settings json file #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked at: https://code.visualstudio.com/api/references/contribution-points#contributes.configuration and found the reason for the error squiggle was simply fixed. All you needed to do is allow for the type to be null here. I've already tested it on my computer by changing it on the extension (in %USERPROFILE%\.vscode\extensions\redvanworkshop.explorer-exclude-vscode-extension-1.2.0 ) and the error squiggle immediately disappeared. No need to make it an empty object or anything.
MatthewTh0
changed the title
MatthewTh0
changed the title
|
Sorry, wasn't sure that renaming the branch would mess up the pull request or not. Also, my bad on changing the title unnecessarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at: https://code.visualstudio.com/api/references/contribution-points#contributes.configuration and found the reason for the error squiggle was simply fixed. All you needed to do is allow for the type to be null here. I've already tested it on my computer by changing it on the extension (in %USERPROFILE%.vscode\extensions\redvanworkshop.explorer-exclude-vscode-extension-1.2.0 since I'm currently using Windows) and the error squiggle immediately disappeared. No need to make it an empty object or anything.
What's this PR do?
Fixes the error squiggle in a user's settings file (workspace.code-workspace or settings.json) by allowing the type to be null.
Where should the reviewer start?
(https://code.visualstudio.com/api/references/contribution-points#contributes.configuration)
How should this be manually tested?
Change it in the extension (which I found here): https://code.visualstudio.com/docs/editor/extension-marketplace#_where-are-extensions-installed
Any background context you want to provide?
I was really annoyed at that squiggle and after trying to mess with JSON schemas for a while, decided to see if I could fix it here. I eventually searched for something like "vscode settings null" and found several configuration options have null as a default. I then searched "vscode extension configuration" and figured out the issue.
What are the relevant github issue?
While it was closed, I found a quick fix for the issue. (#24)
What gif best describes this PR or how it makes you feel?
(I was messing with schemas for hours, on and off, and was having some OCD-like tendencies about the squiggle).
Definition of Done:
npm testpasses without issue (have no idea where this is, couldn't find it after seeing it's supposed to be in, I think, the package.json under the "script" section)