Fix CNOT error model to include 15 error terms #565
Conversation
…able of creating depolarizing channel)
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion
quisp/utils/UtilFunctions.h line 36 at r1 (raw file):
} } return (--weights.end())->first;
What is this part doing?
There was a problem hiding this comment.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @res6idue)
quisp/utils/UtilFunctions.h line 36 at r1 (raw file):
Previously, res6idue (soon) wrote…
What is this part doing?
It is to make sure that there is a return value from sampling.
Since we are traversing the map in forward direction, if somehow the weight summation fails, this will return the last value. Practicaly, it shouldn't happen but it does suppress the compiler warning and more semantically correct.
There was a problem hiding this comment.
Reviewed 1 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Naphann)
The current CNOT error model was incomplete. It can only cover 9 Pauli errors instead of 15, which covers all Pauli channels for 2 qubits.
This closes #563.
This change is