-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bw hash edits v2 #82
Open
bmwwoo
wants to merge
12
commits into
ec-hash-edits
Choose a base branch
from
bw-hash-edits-v2
base: ec-hash-edits
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bw hash edits v2 #82
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e428912
Add favicon
3799821
Merge pull request #75 from sf-interns/jc-favicon
bmwwoo 96b897c
Add twitter share button
bmwwoo e4330b8
Create twitter service
bmwwoo 7eeafa4
Merge pull request #78 from sf-interns/bw-add-twitter
bmwwoo 4f732d1
Build twtter share bundle
bmwwoo 5065aaa
Refactor to align with leveler branch
bmwwoo 3cd6d4f
Revert facebook sharing
bmwwoo 7c3a3bc
Revert reset button change
bmwwoo 57880c9
Rebase twitter code
bmwwoo 1990098
Fix merge/rebase to master
bmwwoo 2e19b82
Fix whitespace
bmwwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,8 @@ | ||
$ = require 'jquery' | ||
TwitterGameService = require './TwitterGameService' | ||
|
||
class ShareGameService | ||
|
||
@setMessage: -> | ||
possible = ['Play MathSwipe with me! Try to beat my score at', | ||
'Play MathSwipe with me! Try to solve my board at', | ||
'Play MathSwipe with me! Solve my puzzle at'] | ||
text = possible[Math.floor(Math.random() * 3)] | ||
$( '#tweet' ).attr( 'data-text' , text ) | ||
console.log $('#fb-share') | ||
$( '#fb-share' ).attr( 'data-href' , window.location.hash ) | ||
TwitterGameService.setTweet() | ||
|
||
module.exports = ShareGameService |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
$ = require 'jquery' | ||
|
||
class TwitterGameService | ||
|
||
@setTweet: -> | ||
possible = ['Play MathSwipe with me! Try to beat my score at', | ||
'Play MathSwipe with me! Try to solve my board at', | ||
'Play MathSwipe with me! Solve my puzzle at'] | ||
text = possible[Math.floor(Math.random() * 3)] | ||
$( '#tweet' ).attr( 'data-text' , text ) | ||
|
||
module.exports = TwitterGameService |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #77 we determine the length from the leveler here instead of as a parameter.